diff --git a/scripts/native/file/rec-legal-customer-product-directory-1.0-native-quarkus-jdk17-runner b/scripts/native/file/rec-legal-customer-product-directory-1.0-native-quarkus-jdk17-runner index 5d4eb8e..f87e5fe 100644 Binary files a/scripts/native/file/rec-legal-customer-product-directory-1.0-native-quarkus-jdk17-runner and b/scripts/native/file/rec-legal-customer-product-directory-1.0-native-quarkus-jdk17-runner differ diff --git a/src/main/java/com/banesco/common/application/helper/RequestValidatorHelper.java b/src/main/java/com/banesco/common/application/helper/RequestValidatorHelper.java index 5f57730..e23742f 100644 --- a/src/main/java/com/banesco/common/application/helper/RequestValidatorHelper.java +++ b/src/main/java/com/banesco/common/application/helper/RequestValidatorHelper.java @@ -12,6 +12,9 @@ import lombok.extern.slf4j.Slf4j; public class RequestValidatorHelper { private final RequestValidationConfig config; + private static final String REQUIRED_CODE = "VDE01"; + private static final String VALIDATE_CODE = "VDE02"; + @Inject public RequestValidatorHelper( RequestValidationConfig config @@ -30,18 +33,18 @@ public class RequestValidatorHelper { public void validateFieldValues( LegalCustomerProductDirectoryRequest request ) { - validate(request.getCustomerId(), config.customerId(), "customerId"); + validate(request.getCustomerId(), config.customerIdNumber(), "customerId"); } private void required(String value, String fieldName) { if (value == null || value.trim().isEmpty()) { - throw HttpStatusCodeException.badRequest("VDE01", fieldName); + throw HttpStatusCodeException.badRequest(REQUIRED_CODE, fieldName); } } private void validate(String value, String regex, String fieldName) { if (value != null && !value.isEmpty() && !value.matches(regex)) { - throw HttpStatusCodeException.badRequest("VDE02", fieldName); + throw HttpStatusCodeException.badRequest(VALIDATE_CODE, fieldName); } } } diff --git a/src/main/java/com/banesco/common/domain/model/HttpRequest.java b/src/main/java/com/banesco/common/domain/model/HttpRequest.java index af48ca7..35a46e8 100644 --- a/src/main/java/com/banesco/common/domain/model/HttpRequest.java +++ b/src/main/java/com/banesco/common/domain/model/HttpRequest.java @@ -58,103 +58,117 @@ public class HttpRequest { private boolean logResponseBody = true; public static HttpRequest forApiResponse( - String url, - HttpMethod method, - Class dataType + String url, + HttpMethod method, + Class dataType ) { return HttpRequest.builder() - .url(url) - .method(method) - .responseType(ApiResponse.class) - .genericType(dataType) - .apiResponse(true) - .build(); + .url(url) + .method(method) + .responseType(ApiResponse.class) + .genericType(dataType) + .apiResponse(true) + .build(); } public static HttpRequest forApiResponseList( - String url, - HttpMethod method, - Class elementType + String url, + HttpMethod method, + Class elementType ) { return HttpRequest.builder() - .url(url) - .method(method) - .responseType(ApiResponse.class) - .complexType(TypeBuilder.listOf(elementType)) - .apiResponse(true) - .listResponse(true) - .build(); + .url(url) + .method(method) + .responseType(ApiResponse.class) + .complexType(TypeBuilder.listOf(elementType)) + .apiResponse(true) + .listResponse(true) + .build(); } public static HttpRequest forApiPrivateResponse( - String url, - String statusSuccess, - HttpMethod method, - Class successType + String url, + String statusSuccess, + HttpMethod method, + Class successType ) { return HttpRequest.builder() - .url(url) - .method(method) - .responseType(ApiPrivateResponse.class) - .complexType(TypeBuilder.parametricType( - Either.class, - successType, - ApiPrivateError.class - )) - .apiPrivateResponse(true) - .eitherResponse(true) - .errorType(ApiPrivateError.class) - .statusSuccess(statusSuccess) - .build(); + .url(url) + .method(method) + .responseType(ApiPrivateResponse.class) + .complexType(TypeBuilder.parametricType( + Either.class, + successType, + ApiPrivateError.class + )) + .apiPrivateResponse(true) + .eitherResponse(true) + .errorType(ApiPrivateError.class) + .statusSuccess(statusSuccess) + .build(); } public static HttpRequest forApiPrivateResponseList( - String url, - String statusSuccess, - HttpMethod method, - Class elementType + String url, + String statusSuccess, + HttpMethod method, + Class elementType ) { return HttpRequest.builder() - .url(url) - .method(method) - .responseType(ApiPrivateResponse.class) - .complexType(TypeBuilder.parametricType( - Either.class, - TypeBuilder.listOf(elementType), - ApiPrivateError.class - )) - .apiPrivateResponse(true) - .eitherResponse(true) - .listResponse(true) - .errorType(ApiPrivateError.class) - .statusSuccess(statusSuccess) - .build(); + .url(url) + .method(method) + .responseType(ApiPrivateResponse.class) + .complexType(TypeBuilder.parametricType( + Either.class, + TypeBuilder.listOf(elementType), + ApiPrivateError.class + )) + .apiPrivateResponse(true) + .eitherResponse(true) + .listResponse(true) + .errorType(ApiPrivateError.class) + .statusSuccess(statusSuccess) + .build(); } public static HttpRequest forDirectResponse( - String url, - HttpMethod method, - Class responseType + String url, + HttpMethod method, + Class responseType ) { return HttpRequest.builder() - .url(url) - .method(method) - .responseType(responseType) - .build(); + .url(url) + .method(method) + .responseType(responseType) + .build(); + } + + public static HttpRequest forDirectResponse( + String url, + HttpMethod method, + Class responseType, + Class errorType + ) { + return HttpRequest.builder() + .url(url) + .method(method) + .responseType(responseType) + .errorType(errorType) + .build(); } public static HttpRequest forGenericResponse( - String url, - HttpMethod method, - Class rawType, - Class genericType + String url, + HttpMethod method, + Class rawType, + Class genericType ) { return HttpRequest.builder() - .url(url) - .method(method) - .responseType(rawType) - .complexType(TypeBuilder.parametricType(rawType, genericType)) - .build(); + .url(url) + .method(method) + .responseType(rawType) + .complexType(TypeBuilder.parametricType(rawType, genericType)) + .build(); } public HttpRequest withHeaders(Map headers) { diff --git a/src/main/java/com/banesco/common/infrastructure/config/RequestValidationConfig.java b/src/main/java/com/banesco/common/infrastructure/config/RequestValidationConfig.java index 2933af6..689b4d3 100644 --- a/src/main/java/com/banesco/common/infrastructure/config/RequestValidationConfig.java +++ b/src/main/java/com/banesco/common/infrastructure/config/RequestValidationConfig.java @@ -4,7 +4,7 @@ import io.smallrye.config.ConfigMapping; @ConfigMapping(prefix = "api.allowed.request-validation") public interface RequestValidationConfig { - String customerId(); + String customerIdNumber(); String accountStatus(); String productCvCode(); String limitType(); diff --git a/src/main/java/com/banesco/module/legal_customer_product_directory/infrastructure/resource/LegalCustomerProductDirectoryResource.java b/src/main/java/com/banesco/module/legal_customer_product_directory/infrastructure/resource/LegalCustomerProductDirectoryResource.java index 200c12b..021722d 100644 --- a/src/main/java/com/banesco/module/legal_customer_product_directory/infrastructure/resource/LegalCustomerProductDirectoryResource.java +++ b/src/main/java/com/banesco/module/legal_customer_product_directory/infrastructure/resource/LegalCustomerProductDirectoryResource.java @@ -318,7 +318,7 @@ public class LegalCustomerProductDirectoryResource { }) public Response retrieve( @HeaderParam("customerReferenceFintechId") - @Parameter(description = "ID de la fintech", required = true, example = "pranical-test") + @Parameter(description = "ID de la fintech", required = true, example = "provider-test") String customerReferenceFintechId, @HeaderParam("appId") diff --git a/src/main/resources/application-dev.yml b/src/main/resources/application-dev.yml index e096add..bc48ad7 100644 --- a/src/main/resources/application-dev.yml +++ b/src/main/resources/application-dev.yml @@ -10,7 +10,7 @@ api: source-id: RLCPD allowed: request-validation: - customer-id: '\d+' + customer-id-number: '\d+' account-status: '^(A|D|ACTBSUSD)$' product-cv-code: '^(CV|CVFL)$' limit-type: '^(PAG|REC)$' @@ -21,6 +21,6 @@ api: rec-legal-customer-product-directory: messages: key: 'rec-legal-customer-product-directory' - content: '[{"backendCode":"200","httpCode":200,"statusCode":"200","description":"Operacion exitosa"},{"backendCode":"R404","httpCode":404,"statusCode":"404","description":"Datos de validacion no encontrado."},{"backendCode":"503","httpCode":503,"statusCode":"503","description":"Uso interno"},{"backendCode":"422","httpCode":422,"statusCode":"422","description":"Uso interno"},{"backendCode":"500","httpCode":500,"statusCode":"500","description":"Uso interno"},{"backendCode":"100","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"OSB-382505","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"OSB-380002","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"ERROR","httpCode":400,"statusCode":"400","description":"Uso interno"},{"backendCode":"400","httpCode":400,"statusCode":"400","description":"Uso interno"},{"backendCode":"401","httpCode":401,"statusCode":"401","description":"Uso interno"},{"backendCode":"403","httpCode":403,"statusCode":"403","description":"Uso interno"},{"backendCode":"404","httpCode":404,"statusCode":"404","description":"Uso interno"},{"backendCode":"default","httpCode":409,"statusCode":"409","description":"Conflicto"},{"backendCode":"424","httpCode":424,"statusCode":"424","description":"Error de dependencia"},{"backendCode":"VDE01","httpCode":400,"statusCode":"VDE01","description":"VDE01 - Error en dato de entrada obligatorio: %s"},{"backendCode":"VDE02","httpCode":400,"statusCode":"VDE02","description":"VDE02 - Error en valor permitido para campo: %s"},{"backendCode":"VRN04","httpCode":"503","statusCode":"VRN04","description":"Servicio en horario de mantenimiento","status":"error"},{"backendCode":"VRN01","httpCode":"400","statusCode":"VRN01","description":"Campo Codigo de IBS Requerido"},{"backendCode":"VRN02","httpCode":"204","statusCode":"VRN02","description":"Cliente sin productos"}]' + content: '[{"backendCode":"200","httpCode":200,"statusCode":"200","description":"Operacion exitosa"},{"backendCode":"R404","httpCode":404,"statusCode":"404","description":"Datos de validacion no encontrado."},{"backendCode":"503","httpCode":503,"statusCode":"503","description":"Uso interno"},{"backendCode":"422","httpCode":422,"statusCode":"422","description":"Uso interno"},{"backendCode":"500","httpCode":500,"statusCode":"500","description":"Uso interno"},{"backendCode":"100","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"OSB-382505","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"OSB-380002","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"ERROR","httpCode":400,"statusCode":"400","description":"Uso interno"},{"backendCode":"400","httpCode":400,"statusCode":"400","description":"Uso interno"},{"backendCode":"401","httpCode":401,"statusCode":"401","description":"Uso interno"},{"backendCode":"403","httpCode":403,"statusCode":"403","description":"Uso interno"},{"backendCode":"404","httpCode":404,"statusCode":"404","description":"Uso interno"},{"backendCode":"default","httpCode":409,"statusCode":"409","description":"Conflicto"},{"backendCode":"424","httpCode":424,"statusCode":"424","description":"Error de dependencia"},{"backendCode":"VDE01","httpCode":400,"statusCode":"VDE01","description":"VDE01 - Error en dato de entrada obligatorio: %s"},{"backendCode":"VDE02","httpCode":400,"statusCode":"VDE02","description":"VDE02 - Error en valor permitido para campo: %s"},{"backendCode":"VRN04","httpCode":503,"statusCode":"VRN04","description":"Servicio en horario de mantenimiento"},{"backendCode":"VRN01","httpCode":400,"statusCode":"VRN01","description":"Campo Codigo de IBS Requerido"},{"backendCode":"VRN02","httpCode":204,"statusCode":"VRN02","description":"Cliente sin productos"}]' rest-client: bus-legal-customer-product-directory: '{"url":"http://localhost:8082/legal-customer-product-directory/retrieve/{customerId}","timeout":{"connect":15000,"response":15000},"config":{}}' \ No newline at end of file diff --git a/src/main/resources/configmap.yaml b/src/main/resources/configmap.yaml index 1d0fb73..862b6a4 100644 --- a/src/main/resources/configmap.yaml +++ b/src/main/resources/configmap.yaml @@ -68,14 +68,13 @@ data: api.allowed.request-validation.limit-type: ^(PAG|REC)$ api.allowed.request-validation.product-cv-code: ^(CV|CVFL)$ api.read-messages.from-props: 'true' - api.rest-client.register-security: '{"url":"http://api-register-security-route-proyecto-prueba-ja.apps.desplakur3.desintra.banesco.com/register-security/save","timeout":{"connect":20000,"response":20000},"config":{"sp":"spAPI_Traza","codEve":"P2PVUEL","codEve2":"P2PVUEL","codBan":"01","codMon":"BS"}}' quarkus.http.port: '8080' api.allowed.request-validation.customer-ibs-number: \d+ quarkus.profile: dev api.allowed.request-validation.account-status: ^(A|O|ACTBSUSD)$ quarkus.log.console.format: '%d{HH:mm:ss.SSS} %-5p [%t] [%X{requestId}] %c{1} - %s%e%n' quarkus.http.idle-timeout: 30s - api.recLogalCustomerProductDirectory.messages.content: '[{"backendCode":"200","httpCode":200,"statusCode":"200","description":"Operacion exitosa"},{"backendCode":"R404","httpCode":404,"statusCode":"404","description":"Datos de validación no encontrado."},{"backendCode":"503","httpCode":503,"statusCode":"503","description":"Uso interno"},{"backendCode":"422","httpCode":422,"statusCode":"422","description":"Uso interno"},{"backendCode":"500","httpCode":500,"statusCode":"500","description":"Uso interno"},{"backendCode":"100","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"OSB-382505","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"OSB-380002","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"ERROR","httpCode":400,"statusCode":"400","description":"Uso interno"},{"backendCode":"400","httpCode":400,"statusCode":"400","description":"Uso interno"},{"backendCode":"401","httpCode":401,"statusCode":"401","description":"Uso interno"},{"backendCode":"403","httpCode":403,"statusCode":"403","description":"Uso interno"},{"backendCode":"404","httpCode":404,"statusCode":"404","description":"Uso interno"},{"backendCode":"default","httpCode":409,"statusCode":"409","description":"Conflicto"},{"backendCode":"424","httpCode":424,"statusCode":"424","description":"Error de dependencia"},{"backendCode":"VDE01","httpCode":400,"statusCode":"VDE01","description":"VDE01 - Error en dato de entrada obligatorio: %s"},{"backendCode":"VDE02","httpCode":400,"statusCode":"VDE02","description":"VDE02 - Error en valor permitido para campo: %s"}]' + api.recLogalCustomerProductDirectory.messages.content: '[{"backendCode":"200","httpCode":200,"statusCode":"200","description":"Operacion exitosa"},{"backendCode":"R404","httpCode":404,"statusCode":"404","description":"Datos de validacion no encontrado."},{"backendCode":"503","httpCode":503,"statusCode":"503","description":"Uso interno"},{"backendCode":"422","httpCode":422,"statusCode":"422","description":"Uso interno"},{"backendCode":"500","httpCode":500,"statusCode":"500","description":"Uso interno"},{"backendCode":"100","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"OSB-382505","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"OSB-380002","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"ERROR","httpCode":400,"statusCode":"400","description":"Uso interno"},{"backendCode":"400","httpCode":400,"statusCode":"400","description":"Uso interno"},{"backendCode":"401","httpCode":401,"statusCode":"401","description":"Uso interno"},{"backendCode":"403","httpCode":403,"statusCode":"403","description":"Uso interno"},{"backendCode":"404","httpCode":404,"statusCode":"404","description":"Uso interno"},{"backendCode":"default","httpCode":409,"statusCode":"409","description":"Conflicto"},{"backendCode":"424","httpCode":424,"statusCode":"424","description":"Error de dependencia"},{"backendCode":"VDE01","httpCode":400,"statusCode":"VDE01","description":"VDE01 - Error en dato de entrada obligatorio: %s"},{"backendCode":"VDE02","httpCode":400,"statusCode":"VDE02","description":"VDE02 - Error en valor permitido para campo: %s"},{"backendCode":"VRN04","httpCode":503,"statusCode":"VRN04","description":"Servicio en horario de mantenimiento"},{"backendCode":"VRN01","httpCode":400,"statusCode":"VRN01","description":"Campo Codigo de IBS Requerido"},{"backendCode":"VRN02","httpCode":204,"statusCode":"VRN02","description":"Cliente sin productos"}]' quarkus.thread-pool.max-threads: '100' quarkus.smallrye-health.liveness-path: /actuator/health/live api.source-id: LCPD