update error messages into private api; update generals

pom.xml

@@ -5,7 +5,7 @@
     <artifactId>rec-create-security-notification</artifactId>
     <version>1.0-native-quarkus-jdk17</version>
     <name>rec-create-security-notification</name>
-    <description>API Reception - Create payment single request</description>
+    <description>API Reception - Create payment alert</description>
 
     <properties>
         <maven.compiler.release>17</maven.compiler.release>

src/main/java/com/banesco/common/application/helper/RequestValidatorHelper.java

@@ -14,6 +14,9 @@ import java.math.BigDecimal;
 public class RequestValidatorHelper {
     private final RequestValidationConfig config;
 
+    private static final String REQUIRED_CODE = "VDE01";
+    private static final String VALIDATE_CODE = "VDE02";
+
     @Inject
     public RequestValidatorHelper(
         RequestValidationConfig config
@@ -41,25 +44,19 @@ public class RequestValidatorHelper {
 
     private void required(String value, String fieldName) {
         if (value == null || value.trim().isEmpty()) {
-            throw HttpStatusCodeException.badRequest("VDE01", fieldName);
+            throw HttpStatusCodeException.badRequest(REQUIRED_CODE, fieldName);
-        }
-    }
-
-    private void required(BigDecimal value, String fieldName) {
-        if (value == null) {
-            throw HttpStatusCodeException.badRequest("VDE01", fieldName);
         }
     }
 
     private void validate(String value, String regex, String fieldName) {
         if (value != null && !value.isEmpty() && !value.matches(regex)) {
-            throw HttpStatusCodeException.badRequest("VDE02", fieldName);
+            throw HttpStatusCodeException.badRequest(VALIDATE_CODE, fieldName);
         }
     }
 
     private void validate(BigDecimal value, String fieldName) {
         if (value != null && value.compareTo(BigDecimal.ZERO) < 1) {
-            throw HttpStatusCodeException.badRequest("VDE02", fieldName);
+            throw HttpStatusCodeException.badRequest(VALIDATE_CODE, fieldName);
         }
     }
 }

src/main/java/com/banesco/common/domain/model/HttpRequest.java

@@ -143,6 +143,20 @@ public class HttpRequest {
                 .build();
     }
 
+    public static <T, R> HttpRequest forDirectResponse(
+            String url,
+            HttpMethod method,
+            Class<T> responseType,
+            Class<R> errorType
+    ) {
+        return HttpRequest.builder()
+                .url(url)
+                .method(method)
+                .responseType(responseType)
+                .errorType(errorType)
+                .build();
+    }
+
     public static <T, U> HttpRequest forGenericResponse(
             String url,
             HttpMethod method,

src/main/java/com/banesco/module/correspondence/infrastructure/resource/CorrespondenceResource.java

@@ -217,7 +217,7 @@ public class CorrespondenceResource {
     })
     public Response initiate(
         @HeaderParam("customerReferenceFintechId")
-        @Parameter(description = "ID de la fintech", required = true, example = "pranical-test")
+        @Parameter(description = "ID de la fintech", required = true, example = "provider-test")
         String customerReferenceFintechId,
 
         @HeaderParam("appId")

src/main/java/com/banesco/module/instruction/domain/model/Instruction.java

@@ -12,5 +12,5 @@ import lombok.*;
 @RegisterForReflection
 @JsonInclude(JsonInclude.Include.NON_NULL)
 public class Instruction {
-    private String instructionPurposeType;       // Request JSON: "channelOrigin" (BOL)
+    private String instructionPurposeType;       // Request JSON: "channelOrigin" (consolaPredictiva)
 }

src/main/resources/application-dev.yml

@@ -17,6 +17,6 @@ api:
   rec-create-security-notification:
     messages:
       key: 'rec-create-security-notification'
-      content: '[{"backendCode":"200","httpCode":200,"statusCode":"200","description":"Operacion exitosa"},{"backendCode":"R404","httpCode":404,"statusCode":"404","description":"Datos de validacion no encontrado."},{"backendCode":"503","httpCode":503,"statusCode":"503","description":"Uso interno"},{"backendCode":"422","httpCode":422,"statusCode":"422","description":"Uso interno"},{"backendCode":"500","httpCode":500,"statusCode":"500","description":"Uso interno"},{"backendCode":"100","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"OSB-382505","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"OSB-380002","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"ERROR","httpCode":400,"statusCode":"400","description":"Uso interno"},{"backendCode":"400","httpCode":400,"statusCode":"400","description":"Uso interno"},{"backendCode":"401","httpCode":401,"statusCode":"401","description":"Uso interno"},{"backendCode":"403","httpCode":403,"statusCode":"403","description":"Uso interno"},{"backendCode":"404","httpCode":404,"statusCode":"404","description":"Uso interno"},{"backendCode":"default","httpCode":409,"statusCode":"409","description":"Conflicto"},{"backendCode":"424","httpCode":424,"statusCode":"424","description":"Error de dependencia"},{"backendCode":"VDE01","httpCode":400,"statusCode":"VDE01","description":"VDE01 - Error en dato de entrada obligatorio: %s"},{"backendCode":"VDE02","httpCode":400,"statusCode":"VDE02","description":"VDE02 - Error en valor permitido para campo: %s"},{"backendCode":"VRN04","httpCode":"503","statusCode":"VRN04","description":"Servicio en horario de mantenimiento","status":"error"},{"backendCode":"VRN02","httpCode":"204","statusCode":"VRN02","description":"Cliente sin productos"}]'
+      content: '[{"backendCode":"200","httpCode":200,"statusCode":"200","description":"Operacion exitosa"},{"backendCode":"R404","httpCode":404,"statusCode":"404","description":"Datos de validacion no encontrado."},{"backendCode":"503","httpCode":503,"statusCode":"503","description":"Uso interno"},{"backendCode":"422","httpCode":422,"statusCode":"422","description":"Uso interno"},{"backendCode":"500","httpCode":500,"statusCode":"500","description":"Uso interno"},{"backendCode":"100","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"OSB-382505","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"OSB-380002","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"ERROR","httpCode":400,"statusCode":"400","description":"Uso interno"},{"backendCode":"400","httpCode":400,"statusCode":"400","description":"Uso interno"},{"backendCode":"401","httpCode":401,"statusCode":"401","description":"Uso interno"},{"backendCode":"403","httpCode":403,"statusCode":"403","description":"Uso interno"},{"backendCode":"404","httpCode":404,"statusCode":"404","description":"Uso interno"},{"backendCode":"default","httpCode":409,"statusCode":"409","description":"Conflicto"},{"backendCode":"424","httpCode":424,"statusCode":"424","description":"Error de dependencia"},{"backendCode":"VDE01","httpCode":400,"statusCode":"VDE01","description":"VDE01 - Error en dato de entrada obligatorio: %s"},{"backendCode":"VDE02","httpCode":400,"statusCode":"VDE02","description":"VDE02 - Error en valor permitido para campo: %s"},{"backendCode":"VRN04","httpCode":503,"statusCode":"VRN04","description":"Servicio en horario de mantenimiento"},{"backendCode":"PIB-00","httpCode":409,"statusCode":"PIB-00","description":"Error Interno backend"},{"backendCode":"PIB-01","httpCode":409,"statusCode":"PIB-01","description":"Error Interno backend"}]'
   rest-client:
     bus-create-security-notification: '{"url":"http://localhost:8082/correspondence/initiate","timeout":{"connect":15000,"response":15000},"config":{}}'

src/main/resources/configmap.yaml

@@ -59,7 +59,7 @@ data:
   quarkus.debug.print-startup-times: 'true'
   quarkus.swagger-ui.path: /swagger-ui
   quarkus.application.name: rec-create-security-notification
-  api.rec-create-security-notification.messages.content: '[{"backendCode":"200","httpCode":200,"statusCode":"200","description":"Operacion exitosa"},{"backendCode":"R404","httpCode":404,"statusCode":"404","description":"Datos de validacion no encontrado."},{"backendCode":"503","httpCode":503,"statusCode":"503","description":"Uso interno"},{"backendCode":"422","httpCode":422,"statusCode":"422","description":"Uso interno"},{"backendCode":"500","httpCode":500,"statusCode":"500","description":"Uso interno"},{"backendCode":"100","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"OSB-382505","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"OSB-380002","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"ERROR","httpCode":400,"statusCode":"400","description":"Uso interno"},{"backendCode":"400","httpCode":400,"statusCode":"400","description":"Uso interno"},{"backendCode":"401","httpCode":401,"statusCode":"401","description":"Uso interno"},{"backendCode":"403","httpCode":403,"statusCode":"403","description":"Uso interno"},{"backendCode":"404","httpCode":404,"statusCode":"404","description":"Uso interno"},{"backendCode":"default","httpCode":409,"statusCode":"409","description":"Conflicto"},{"backendCode":"424","httpCode":424,"statusCode":"424","description":"Error de dependencia"},{"backendCode":"VDE01","httpCode":400,"statusCode":"VDE01","description":"VDE01 - Error en dato de entrada obligatorio: %s"},{"backendCode":"VDE02","httpCode":400,"statusCode":"VDE02","description":"VDE02 - Error en valor permitido para campo: %s"},{"backendCode":"VRN04","httpCode":"503","statusCode":"VRN04","description":"Servicio en horario de mantenimiento","status":"error"},{"backendCode":"204","httpCode":"200","statusCode":"200","description":"Cliente sin productos","status":"ok"}]'
+  api.rec-create-security-notification.messages.content: '[{"backendCode":"200","httpCode":200,"statusCode":"200","description":"Operacion exitosa"},{"backendCode":"R404","httpCode":404,"statusCode":"404","description":"Datos de validacion no encontrado."},{"backendCode":"503","httpCode":503,"statusCode":"503","description":"Uso interno"},{"backendCode":"422","httpCode":422,"statusCode":"422","description":"Uso interno"},{"backendCode":"500","httpCode":500,"statusCode":"500","description":"Uso interno"},{"backendCode":"100","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"OSB-382505","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"OSB-380002","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"ERROR","httpCode":400,"statusCode":"400","description":"Uso interno"},{"backendCode":"400","httpCode":400,"statusCode":"400","description":"Uso interno"},{"backendCode":"401","httpCode":401,"statusCode":"401","description":"Uso interno"},{"backendCode":"403","httpCode":403,"statusCode":"403","description":"Uso interno"},{"backendCode":"404","httpCode":404,"statusCode":"404","description":"Uso interno"},{"backendCode":"default","httpCode":409,"statusCode":"409","description":"Conflicto"},{"backendCode":"424","httpCode":424,"statusCode":"424","description":"Error de dependencia"},{"backendCode":"VDE01","httpCode":400,"statusCode":"VDE01","description":"VDE01 - Error en dato de entrada obligatorio: %s"},{"backendCode":"VDE02","httpCode":400,"statusCode":"VDE02","description":"VDE02 - Error en valor permitido para campo: %s"},{"backendCode":"VRN04","httpCode":503,"statusCode":"VRN04","description":"Servicio en horario de mantenimiento"},{"backendCode":"PIB-00","httpCode":409,"statusCode":"PIB-00","description":"Error Interno backend"},{"backendCode":"PIB-01","httpCode":409,"statusCode":"PIB-01","description":"Error Interno backend"}]'
   quarkus.smallrye-health.ui.enable: 'false'
   quarkus.swagger-ui.always-include: 'true'
   api.rest-client.bus-create-security-notification: '{"url":"http://bus-create-security-notification-route-proyecto-prueba-ja.apps.desplakur3.desintra.banesco.com/correspondence/initiate","timeout":{"connect":15000,"response":15000},"config":{}}'