From 704cff9d69326b399fa81d7749ecbbd1ec5ac13f Mon Sep 17 00:00:00 2001 From: Ramon Ramirez Date: Tue, 13 Jan 2026 17:30:00 -0400 Subject: [PATCH] update organization type name --- .../application/helper/MessageHelper.java | 10 +++---- .../common/domain/model/Agreement.java | 2 +- .../common/domain/model/Arrangement.java | 2 +- .../module/account/domain/model/Account.java | 12 ++++---- .../domain/model/AccountInvolvement.java | 2 +- .../LegalCustomerProductDirectoryService.java | 8 ++--- .../LegalCustomerProductDirectoryRequest.java | 12 ++++---- .../persistence/mapper/AccountMapper.java | 4 +-- .../repository/AccountRepository.java | 12 ++++---- ...LegalCustomerProductDirectoryResource.java | 30 +++++++++---------- .../module/party/domain/model/PartyType.java | 2 +- src/main/resources/application-dev.yml | 2 +- src/main/resources/application.yml | 6 ++-- 13 files changed, 52 insertions(+), 52 deletions(-) diff --git a/src/main/java/com/banesco/common/application/helper/MessageHelper.java b/src/main/java/com/banesco/common/application/helper/MessageHelper.java index ee26bf0..2bf57bc 100644 --- a/src/main/java/com/banesco/common/application/helper/MessageHelper.java +++ b/src/main/java/com/banesco/common/application/helper/MessageHelper.java @@ -123,7 +123,7 @@ public class MessageHelper { } if (json == null || json.isEmpty()) { - log.warn("No se encontró JSON de errores"); + log.warn("No se encontro JSON de errores"); return createDefaultMappings(); } @@ -138,11 +138,11 @@ public class MessageHelper { result.put(mapping.getBackendCode(), mapping); } } else { - log.warn("Ignorando mapping sin backendCode válido: {}", mapping.getDescription()); + log.warn("Ignorando mapping sin backendCode valido: {}", mapping.getDescription()); } } - log.info("Mappings de errores cargados exitosamente, total válidos: {}", result.size()); + log.info("Mappings de errores cargados exitosamente, total validos: {}", result.size()); return result; } catch (Exception e) { log.error("Error cargando mappings de errores: {}", e.getMessage()); @@ -153,7 +153,7 @@ public class MessageHelper { private String loadFromJsonFile() { try (InputStream is = MessageHelper.class.getClassLoader().getResourceAsStream(ERROR_FILE_PATH)) { if (is == null) { - log.warn("No se encontró el archivo de errores: {}", ERROR_FILE_PATH); + log.warn("No se encontro el archivo de errores: {}", ERROR_FILE_PATH); return ""; } return new String(is.readAllBytes()); @@ -184,7 +184,7 @@ public class MessageHelper { mapping.setBackendCode(SUCCESS_DEFAULT); mapping.setHttpCode(200); mapping.setStatusCode("200"); - mapping.setDescription("Operación exitosa"); + mapping.setDescription("Operacion exitosa"); return mapping; } diff --git a/src/main/java/com/banesco/common/domain/model/Agreement.java b/src/main/java/com/banesco/common/domain/model/Agreement.java index eabbaff..ce8c3f0 100644 --- a/src/main/java/com/banesco/common/domain/model/Agreement.java +++ b/src/main/java/com/banesco/common/domain/model/Agreement.java @@ -15,6 +15,6 @@ import java.util.List; @RegisterForReflection @JsonInclude(JsonInclude.Include.NON_NULL) public class Agreement { - @Schema(description = "Información del arreglo de la cuenta") + @Schema(description = "Informacion del arreglo de la cuenta") private List arrangement; } diff --git a/src/main/java/com/banesco/common/domain/model/Arrangement.java b/src/main/java/com/banesco/common/domain/model/Arrangement.java index 52ee99a..7342502 100644 --- a/src/main/java/com/banesco/common/domain/model/Arrangement.java +++ b/src/main/java/com/banesco/common/domain/model/Arrangement.java @@ -13,6 +13,6 @@ import org.eclipse.microprofile.openapi.annotations.media.Schema; @RegisterForReflection @JsonInclude(JsonInclude.Include.NON_NULL) public class Arrangement { - @Schema(description = "Información del tipo de arreglo de la cuenta (Si la cuenta corriente tiene interés)") + @Schema(description = "Informacion del tipo de arreglo de la cuenta (Si la cuenta corriente tiene interes)") private ArrangementType arrangementType; } diff --git a/src/main/java/com/banesco/module/account/domain/model/Account.java b/src/main/java/com/banesco/module/account/domain/model/Account.java index c3d5ca4..a38ae7e 100644 --- a/src/main/java/com/banesco/module/account/domain/model/Account.java +++ b/src/main/java/com/banesco/module/account/domain/model/Account.java @@ -18,18 +18,18 @@ import java.util.List; public class Account { @Schema(description = "Estado de la cuenta") private AccountStatus accountStatus; - @Schema(description = "Lista de datos de identificación de la cuenta") + @Schema(description = "Lista de datos de identificacion de la cuenta") private List accountIdentification; @Schema(description = "Tipo de cuenta") private AccountType accountType; - @Schema(description = "Información de los tipos de balances de la cuenta") + @Schema(description = "Informacion de los tipos de balances de la cuenta") private List accountBalance; - @Schema(description = "Información de la moneda de la cuenta") + @Schema(description = "Informacion de la moneda de la cuenta") private List accountCurrency; - @Schema(description = "Información complementaria de la cuenta") + @Schema(description = "Informacion complementaria de la cuenta") private List accountInvolvement; - @Schema(description = "Información relacional de la cuenta con otras o consigo misma") + @Schema(description = "Informacion relacional de la cuenta con otras o consigo misma") private List accountRelationship; - @Schema(description = "Información del acuerdo de la cuenta") + @Schema(description = "Informacion del acuerdo de la cuenta") private List agreement; } \ No newline at end of file diff --git a/src/main/java/com/banesco/module/account/domain/model/AccountInvolvement.java b/src/main/java/com/banesco/module/account/domain/model/AccountInvolvement.java index 1c983d6..fda6f86 100644 --- a/src/main/java/com/banesco/module/account/domain/model/AccountInvolvement.java +++ b/src/main/java/com/banesco/module/account/domain/model/AccountInvolvement.java @@ -13,6 +13,6 @@ import org.eclipse.microprofile.openapi.annotations.media.Schema; @RegisterForReflection public class AccountInvolvement { private AccountInvolvementType accountInvolvementType; - @Schema(description = "Información del cliente") + @Schema(description = "Informacion del cliente") private Party partyReference; } diff --git a/src/main/java/com/banesco/module/legal_customer_product_directory/application/service/LegalCustomerProductDirectoryService.java b/src/main/java/com/banesco/module/legal_customer_product_directory/application/service/LegalCustomerProductDirectoryService.java index 9272a36..0a3fd37 100644 --- a/src/main/java/com/banesco/module/legal_customer_product_directory/application/service/LegalCustomerProductDirectoryService.java +++ b/src/main/java/com/banesco/module/legal_customer_product_directory/application/service/LegalCustomerProductDirectoryService.java @@ -31,18 +31,18 @@ public class LegalCustomerProductDirectoryService implements LegalCustomerProduc public ApiResponse execute( LegalCustomerProductDirectoryRequest request ) { - log.info("Iniciando ejecución para el cliente: {}", request.getCustomerIbsNumber()); + log.info("Iniciando ejecucion para el cliente: {}", request.getCustomerIbsNumber()); try { return storeProcedure(request); } catch (PersistenceException e) { - log.warn("Excepción de la persistencia del sp: {} -> {}", e.getErrorCode(), e.getMessage()); + log.warn("Excepcion de la persistencia del sp: {} -> {}", e.getErrorCode(), e.getMessage()); throw HttpStatusCodeException.badRequest(e.getErrorCode()); } catch (HttpStatusCodeException e) { - log.error("Excepción HTTP del api de dominio: {} - {}", e.getStatusCode(), e.getErrorCode()); + log.error("Excepcion HTTP del api de dominio: {} - {}", e.getStatusCode(), e.getErrorCode()); throw e; } catch (Exception e) { - log.error("Excepción genérica del api de dominio: {}", e.getMessage()); + log.error("Excepcion generica del api de dominio: {}", e.getMessage()); throw e; } } diff --git a/src/main/java/com/banesco/module/legal_customer_product_directory/domain/dto/request/LegalCustomerProductDirectoryRequest.java b/src/main/java/com/banesco/module/legal_customer_product_directory/domain/dto/request/LegalCustomerProductDirectoryRequest.java index 615432e..9914401 100644 --- a/src/main/java/com/banesco/module/legal_customer_product_directory/domain/dto/request/LegalCustomerProductDirectoryRequest.java +++ b/src/main/java/com/banesco/module/legal_customer_product_directory/domain/dto/request/LegalCustomerProductDirectoryRequest.java @@ -15,16 +15,16 @@ public class LegalCustomerProductDirectoryRequest { @NonNull private String appId; // Header obligatorio @NonNull - private String customerIbsNumber; // VCUSCUN - Obligatorio (Número de cliente IBS) + private String customerIbsNumber; // VCUSCUN - Obligatorio (Numero de cliente IBS) - private String bankNumber; // VACMBNK - Número de Banco (filtro) + private String bankNumber; // VACMBNK - Numero de Banco (filtro) private String currencyCode; // VACMCCY - Moneda (filtro) private String accountStatus; // VACMAST - Estatus de Cuenta (filtro) - private String productCvCode; // VACMPROCV - Código de Producto Cuenta Verde (filtro) - private String productCode; // VACMPRO - Código de Producto (filtro) - private String channelCode; // VAFILICANAL - Código de Canal (filtro) + private String productCvCode; // VACMPROCV - Codigo de Producto Cuenta Verde (filtro) + private String productCode; // VACMPRO - Codigo de Producto (filtro) + private String channelCode; // VAFILICANAL - Codigo de Canal (filtro) private String serviceType; // VAFILICOSER - Tipo de Servicio (filtro) - private String affiliationStatus; // VAFILISTATU - Estatus de afiliación (filtro) + private String affiliationStatus; // VAFILISTATU - Estatus de afiliacion (filtro) private String limitType; // VALIMIT - Pagador/Receptor (PAG/REC) (filtro) private String casheaIndicator; // VCASHEA - SI/NO (filtro) } \ No newline at end of file diff --git a/src/main/java/com/banesco/module/legal_customer_product_directory/infrastructure/persistence/mapper/AccountMapper.java b/src/main/java/com/banesco/module/legal_customer_product_directory/infrastructure/persistence/mapper/AccountMapper.java index 6c41197..0775337 100644 --- a/src/main/java/com/banesco/module/legal_customer_product_directory/infrastructure/persistence/mapper/AccountMapper.java +++ b/src/main/java/com/banesco/module/legal_customer_product_directory/infrastructure/persistence/mapper/AccountMapper.java @@ -72,7 +72,7 @@ public class AccountMapper { .fullName(response.getNombre()) .build() )) - .partyType(PartyType.ORGANISATION) + .partyType(PartyType.ORGANIZATION) .partyIdentification(List.of( PartyIdentification.builder() .partyIdentificationType(PartyIdentificationType.TAX_IDENTIFICATION_NUMBER) @@ -236,7 +236,7 @@ public class AccountMapper { try { return rs.getBigDecimal(columnName); } catch (SQLException e) { - log.debug("Columna {} no encontrada como numérico, retornando null", columnName); + log.debug("Columna {} no encontrada como numerico, retornando null", columnName); return BigDecimal.valueOf(0.0); } } diff --git a/src/main/java/com/banesco/module/legal_customer_product_directory/infrastructure/persistence/repository/AccountRepository.java b/src/main/java/com/banesco/module/legal_customer_product_directory/infrastructure/persistence/repository/AccountRepository.java index 8a4e9f3..7a672d7 100644 --- a/src/main/java/com/banesco/module/legal_customer_product_directory/infrastructure/persistence/repository/AccountRepository.java +++ b/src/main/java/com/banesco/module/legal_customer_product_directory/infrastructure/persistence/repository/AccountRepository.java @@ -54,7 +54,7 @@ public class AccountRepository { log.info("Iniciando llamada SP: {}", spCall); try (Connection conn = dataSource.getConnection()) { - log.info("Conexión obtenida exitosamente"); + log.info("Conexion obtenida exitosamente"); results = executeStoredProcedure(conn, spCall); if ( @@ -66,13 +66,13 @@ public class AccountRepository { throw new PersistenceException("ERROR", results.get(0).getDscError()); } } catch (SQLException e) { - log.error("Error en conexión o ejecución del SP {}: {}", spCall, e.getMessage()); + log.error("Error en conexion o ejecucion del SP {}: {}", spCall, e.getMessage()); throw new PersistenceException("ERROR", e.getMessage()); } catch (Exception e) { - log.error("Error genérico en la ejecución del SP {}: {}", spCall, e.getMessage()); + log.error("Error generico en la ejecucion del SP {}: {}", spCall, e.getMessage()); throw new PersistenceException("ERROR", e.getMessage()); } finally { - log.info("SP conexión finalizada"); + log.info("SP conexion finalizada"); } log.info("SP completado exitosamente, resultados: {}", results.size()); @@ -108,13 +108,13 @@ public class AccountRepository { } } } else { - log.info("SP no devolvió ResultSet"); + log.info("SP no devolvio ResultSet"); } } catch (SQLException e) { log.error("Error en CallableStatement {}: {}", spCall, e.getMessage()); throw e; } finally { - log.info("Ejecución del SP finalizado"); + log.info("Ejecucion del SP finalizado"); } return results; diff --git a/src/main/java/com/banesco/module/legal_customer_product_directory/infrastructure/resource/LegalCustomerProductDirectoryResource.java b/src/main/java/com/banesco/module/legal_customer_product_directory/infrastructure/resource/LegalCustomerProductDirectoryResource.java index cc19a9f..46300ba 100644 --- a/src/main/java/com/banesco/module/legal_customer_product_directory/infrastructure/resource/LegalCustomerProductDirectoryResource.java +++ b/src/main/java/com/banesco/module/legal_customer_product_directory/infrastructure/resource/LegalCustomerProductDirectoryResource.java @@ -45,12 +45,12 @@ public class LegalCustomerProductDirectoryResource { @Path("/retrieve/{customerIbsNumber : (?!retrieve$).*}") @Operation( summary = "Recuperar productos de cliente legal", - description = "Consulta masiva de cuentas por número de cliente IBS" + description = "Consulta masiva de cuentas por numero de cliente IBS" ) @APIResponses(value = { @APIResponse( responseCode = "200", - description = "Operación exitosa", + description = "Operacion exitosa", content = @Content( mediaType = MediaType.APPLICATION_JSON, schema = @Schema( @@ -142,7 +142,7 @@ public class LegalCustomerProductDirectoryResource { "fullName": "TASCA RESTAURANT GOOD WORLD CEN, C.A." } ], - "partyType": "ORGANISATION", + "partyType": "ORGANIZATION", "partyIdentification": [ { "partyIdentificationType": "TAX_IDENTIFICATION_NUMBER", @@ -186,7 +186,7 @@ public class LegalCustomerProductDirectoryResource { }, "statusResponse": { "statusCode": "200", - "message": "Operación exitosa" + "message": "Operacion exitosa" } } """ @@ -259,7 +259,7 @@ public class LegalCustomerProductDirectoryResource { ), examples = { @ExampleObject( - name = "Error VRN08 - Identificación del fintechId no coincide", + name = "Error VRN08 - Identificacion del fintechId no coincide", value = """ { "data": null, @@ -299,7 +299,7 @@ public class LegalCustomerProductDirectoryResource { "data": null, "statusResponse": { "statusCode": "VRN04", - "message": "El servicio no está disponible fuera del horario operativo" + "message": "El servicio no esta disponible fuera del horario operativo" } } """ @@ -311,7 +311,7 @@ public class LegalCustomerProductDirectoryResource { "data": null, "statusResponse": { "statusCode": "VDR13", - "message": "El servicio OSB no está disponible en este momento" + "message": "El servicio OSB no esta disponible en este momento" } } """ @@ -322,7 +322,7 @@ public class LegalCustomerProductDirectoryResource { }) public Response retrieve( @PathParam("customerIbsNumber") - @Parameter(description = "Número de cliente IBS (VCUSCUN)", example = "200053197") + @Parameter(description = "Numero de cliente IBS (VCUSCUN)", example = "200053197") String customerIbsNumber, @QueryParam("customerReferenceFintechId") @@ -330,15 +330,15 @@ public class LegalCustomerProductDirectoryResource { String customerReferenceFintechId, @QueryParam("appId") - @Parameter(description = "ID de la aplicación", example = "DANIAPP") + @Parameter(description = "ID de la aplicacion", example = "DANIAPP") String appId, @QueryParam("bankNumber") - @Parameter(description = "Número de banco (VACMBNK)", example = "01") + @Parameter(description = "Numero de banco (VACMBNK)", example = "01") String bankNumber, @QueryParam("currencyCode") - @Parameter(description = "Código de moneda (VACMCCY)", example = "BS") + @Parameter(description = "Codigo de moneda (VACMCCY)", example = "BS") String currencyCode, @QueryParam("accountStatus") @@ -346,15 +346,15 @@ public class LegalCustomerProductDirectoryResource { String accountStatus, @QueryParam("productCvCode") - @Parameter(description = "Código de Producto Cuenta Verde (VACMPROCV). 'CV'=Cuenta verde, 'CVFL'=Cuenta verde con opción activa", example = "CV") + @Parameter(description = "Codigo de Producto Cuenta Verde (VACMPROCV). 'CV'=Cuenta verde, 'CVFL'=Cuenta verde con opcion activa", example = "CV") String productCvCode, @QueryParam("productCode") - @Parameter(description = "Código de producto (VACMPRO)", example = "3980") + @Parameter(description = "Codigo de producto (VACMPRO)", example = "3980") String productCode, @QueryParam("channelCode") - @Parameter(description = "Código de canal (VAFILICANAL)", example = "APP") + @Parameter(description = "Codigo de canal (VAFILICANAL)", example = "APP") String channelCode, @QueryParam("serviceType") @@ -362,7 +362,7 @@ public class LegalCustomerProductDirectoryResource { String serviceType, @QueryParam("affiliationStatus") - @Parameter(description = "Estatus de afiliación (VAFILISTATU)", example = "A") + @Parameter(description = "Estatus de afiliacion (VAFILISTATU)", example = "A") String affiliationStatus, @QueryParam("limitType") diff --git a/src/main/java/com/banesco/module/party/domain/model/PartyType.java b/src/main/java/com/banesco/module/party/domain/model/PartyType.java index ec99c5f..07d5e83 100644 --- a/src/main/java/com/banesco/module/party/domain/model/PartyType.java +++ b/src/main/java/com/banesco/module/party/domain/model/PartyType.java @@ -2,5 +2,5 @@ package com.banesco.module.party.domain.model; public enum PartyType { PERSON, - ORGANISATION + ORGANIZATION } diff --git a/src/main/resources/application-dev.yml b/src/main/resources/application-dev.yml index ef19053..06f597a 100644 --- a/src/main/resources/application-dev.yml +++ b/src/main/resources/application-dev.yml @@ -23,7 +23,7 @@ api: dom-legal-customer-product-directory: messages: key: 'dom-legal-customer-product-directory' - content: '[{"backendCode":"200","httpCode":200,"statusCode":"200","description":"Operacion exitosa"},{"backendCode":"R404","httpCode":404,"statusCode":"404","description":"Datos de validación no encontrado."},{"backendCode":"503","httpCode":503,"statusCode":"503","description":"Uso interno"},{"backendCode":"422","httpCode":422,"statusCode":"422","description":"Uso interno"},{"backendCode":"500","httpCode":500,"statusCode":"500","description":"Uso interno"},{"backendCode":"100","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"OSB-382505","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"OSB-380002","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"ERROR","httpCode":400,"statusCode":"400","description":"Uso interno"},{"backendCode":"400","httpCode":400,"statusCode":"400","description":"Uso interno"},{"backendCode":"401","httpCode":401,"statusCode":"401","description":"Uso interno"},{"backendCode":"403","httpCode":403,"statusCode":"403","description":"Uso interno"},{"backendCode":"404","httpCode":404,"statusCode":"404","description":"Uso interno"},{"backendCode":"default","httpCode":409,"statusCode":"409","description":"Conflicto"},{"backendCode":"424","httpCode":424,"statusCode":"424","description":"Error de dependencia"},{"backendCode":"VDE01","httpCode":400,"statusCode":"VDE01","description":"VDE01 - Error en dato de entrada obligatorio: %s"},{"backendCode":"VDE02","httpCode":400,"statusCode":"VDE02","description":"VDE02 - Error en valor permitido para campo: %s"},{"backend_code":"204","http_code":"200","status_code":"200","description":"Cliente sin productos","status":"ok"}]' + content: '[{"backendCode":"200","httpCode":200,"statusCode":"200","description":"Operacion exitosa"},{"backendCode":"R404","httpCode":404,"statusCode":"404","description":"Datos de validacion no encontrado."},{"backendCode":"503","httpCode":503,"statusCode":"503","description":"Uso interno"},{"backendCode":"422","httpCode":422,"statusCode":"422","description":"Uso interno"},{"backendCode":"500","httpCode":500,"statusCode":"500","description":"Uso interno"},{"backendCode":"100","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"OSB-382505","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"OSB-380002","httpCode":503,"statusCode":"503","description":"VDR13 - OSB Disponible"},{"backendCode":"ERROR","httpCode":400,"statusCode":"400","description":"Uso interno"},{"backendCode":"400","httpCode":400,"statusCode":"400","description":"Uso interno"},{"backendCode":"401","httpCode":401,"statusCode":"401","description":"Uso interno"},{"backendCode":"403","httpCode":403,"statusCode":"403","description":"Uso interno"},{"backendCode":"404","httpCode":404,"statusCode":"404","description":"Uso interno"},{"backendCode":"default","httpCode":409,"statusCode":"409","description":"Conflicto"},{"backendCode":"424","httpCode":424,"statusCode":"424","description":"Error de dependencia"},{"backendCode":"VDE01","httpCode":400,"statusCode":"VDE01","description":"VDE01 - Error en dato de entrada obligatorio: %s"},{"backendCode":"VDE02","httpCode":400,"statusCode":"VDE02","description":"VDE02 - Error en valor permitido para campo: %s"},{"backend_code":"204","http_code":"200","status_code":"200","description":"Cliente sin productos","status":"ok"}]' datasource: sp: diff --git a/src/main/resources/application.yml b/src/main/resources/application.yml index 081d7b7..f2a3ef0 100644 --- a/src/main/resources/application.yml +++ b/src/main/resources/application.yml @@ -30,14 +30,14 @@ quarkus: max-lifetime: '900000' leak-detection-interval: '60000' validation-query-sql: 'SELECT 1 FROM SYSIBM.SYSDUMMY1' - # Configuración específica para DB2 + # Configuracion especifica para DB2 additional-jdbc-properties: currentSchema: "BANCYFIL2" retrieveMessagesFromServerOnGetMessage: "true" useJDBC4ColumnNameAndLabelSemantics: "2" health: - # Específica si Quarkus debe registrar automáticamente sus propios health checks para verificar el datasource. - # Cuando está en false Quarkus no registrará su health check de datasource automático + # Especifica si Quarkus debe registrar automaticamente sus propios health checks para verificar el datasource. + # Cuando esta en false Quarkus no registrara su health check de datasource automatico # lo cual es correcto porque ya se tiene un health check personalizado (DatabaseHealthCheck). enabled: false ## OpenApi